ebpf: use TC_ACT_PIPE in classifier #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2024 23:01
Demonstrate using the correct constant instead of a magic number.
This is the default resolver for the 2021 edition, but needs to be set manually in virtual workspaces. https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html#detail
vadorovsky
force-pushed
the
use-tc-act-const
branch
from
ef2a2c6 to
a88f46b
Compare
vadorovsky
approved these changes
May 21, 2024
There was a problem hiding this comment.
Thanks for your contribution! 🙏 And sorry for late reaction.
The content of the PR looks good, but just for the future - please don't mix different changes in the same commit. TC_ACT_PIPE and resolver = "2" are two different, unrelated things. Ideally, they should've been submitted as separate PRs.
For this PR, I just went ahead and split the changes into separate commits. I'm still keeping you as an author of both, I hope GitHub handles that well. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate using the correct constant instead of a magic number.
Also set
resolver = "2"at the workspace's Cargo.toml. This is the default resolver for the 2021 edition, but is a workspace-wide setting needs to be set manually in virtual workspaces. https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html#details