Rename Bpf -> Ebpf #105
Closed
Rename Bpf -> Ebpf #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missed the |
|
@Frohlix Look at the CI failures, they look legit - you still have some |
|
@Frohlix Why did you close this PR? I think it would be good to go after not so many changes. The CI errors were due to If for any reason, you don't want to continue the work on this, I'm happy to take over and preserve your authorship. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of aya-rs/aya#528, the template is out of date and generates broken code.
The first commit fixes the broken dependency (
aya-ebpf).The second commit isn't strictly necessary since
Bpf/BpfLoggerstill work, but they are deprecated.Whether the variable
bpfin{{project-name}}/src/main.rsshould also be renamed toebpfis a question of taste, so I left it out.