Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use aya, aya-ebpf and aya-log from crates.io #107

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

vadorovsky
Copy link
Member

No description provided.

@vadorovsky vadorovsky requested a review from tamird April 15, 2024 15:05
@tamird
Copy link
Member

tamird commented Apr 15, 2024

Rationale?

@vadorovsky
Copy link
Member Author

vadorovsky commented Apr 15, 2024

Rationale?

To use crates from crates.io instead of using git? We finally have ebpf crates published too.

@tamird
Copy link
Member

tamird commented Apr 15, 2024

There was a time that we discouraged that, has that position shifted? Where was it decided?

@vadorovsky
Copy link
Member Author

@alessandrod changed his mind after making latest releases https://discord.com/channels/855676609003651072/855676609003651075/1226142232235474944

I think the position shifted towards trying to do better with often releases. I'm in favor of that, because using Aya as git dep for pulsar was quite a headeache. For context, we are using Yocto with meta-rust which doesn't like git dependencies with workspaces much.

Similar story with @dave-tucker and his work on bpfman, where they do rpm packaging.

@vadorovsky vadorovsky merged commit f642921 into main Apr 16, 2024
20 checks passed
@vadorovsky vadorovsky deleted the aya-ebpf-versioned branch April 16, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants