feat: custom target directory support #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh ofc I broke the base case 🤦♂️ fixing soon! |
gamedolphin
force-pushed
the
feat/custom-target-dir
branch
from
466afc9 to
44e7550
Compare
|
Can you rebase or close this? |
|
This will be closed by #124 which should make the machinery respect CARGO_TARGET_DIR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have CARGO_TARGET_DIR in your config, a new aya project would not compile/execute out of the box. This PR attempts to fix that by reading the CARGO_TARGET_DIR path from the environment and using that to locate the compiled ebpf bundle.