Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: rearrange wm keymaps #1363

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

AngelontheRoad
Copy link
Contributor

I put wm keymaps into keymap/ui.lua and divided them into builtin_map and plug_map. It's strightfoward and maybe you could like it.

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Nov 4, 2024

It make sense to me to move those windows core keymaps to keymap/ui.lua, but it would be even better if you move the remaining edit core keymaps to keymap/editor.lua.

Don't forgot to remove this line, update tutor/dots.tutor and update wiki!

Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AngelontheRoad
Copy link
Contributor Author

It make sense to me to move those windows core keymaps to keymap/ui.lua, but it would be even better if you move the remaining edit core keymaps to keymap/editor.lua.

Don't forgot to remove this line, update tutor/dots.tutor and update wiki!

Right, I've done.

Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also https://github.com/ayamir/nvimdots/wiki/Keybindings is updated.
ready to merge.

@CharlesChiuGit CharlesChiuGit merged commit f475d96 into ayamir:main Nov 4, 2024
Deg2v pushed a commit to Deg2v/nvimdots that referenced this pull request Jan 16, 2025
Jint-lzxy added a commit that referenced this pull request Jan 18, 2025
This is basically a follow-up for #1363! I combined builtin & plugin keymaps,
cleaned up some comments (lol "suckless"), and made `ui.lua` export-ready

Signed-off-by: Jint-lzxy <[email protected]>
ayamir pushed a commit that referenced this pull request Jan 19, 2025
This is basically a follow-up for #1363! I combined builtin & plugin keymaps,
cleaned up some comments (lol "suckless"), and made `ui.lua` export-ready

Signed-off-by: Jint-lzxy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants