Add Clone derivation for Filters
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to have them not be AFAICT and makes certain things easier (e.g. if the filter is part of a data structure whose ownership is being transferred but you want to keep a copy of the filter).
vlovich
force-pushed
the
filter-clone
branch
from
8234a72 to
a923381
Compare
|
Ping. |
|
Thanks! |
|
Hi @ayazhafiz , do you have time to release a new version? |
|
@xudong963 thanks for the ping. 0.11.0 is now released with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to have them not be AFAICT and makes certain things easier (e.g. if the filter is part of a data structure whose ownership is being transferred but you want to keep a copy of the filter).