Use serde_bytes to reduce (de)serilization speed of 8-bit filters by 96% #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that deserialization of the
BinaryFuse8
using serde takes a long time. In my use case with 450 millions members, it takes 2-3 minutes on a modern machine. The majority of this time is spent on the byte-by-byte deserialization of thefingerprints
slice. The specialization offered by the serde_bytes crate solves that exact problem.I also added a benchmark to show the difference and posted the results from a run on an M2 MacBook below.
Before:
After: