Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check hash of firmware #26

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Conversation

qistoph
Copy link
Contributor

@qistoph qistoph commented Jul 25, 2020

This PR sends an MD5 hash along with the uploaded firmware and checks on the ESP if the received data matches the hash.

It's based on the same functionality in ESP8266httpUpdate.

I have not updated the server side code in this repo yet, but a working example is included in the PR at your AsyncElegantOTA repo.

TODO:

  • Handle MD5 param in ESP8266 code
  • Handle MD5 param in ESP32 code

I would like your feedback on this to determine if it's worth spending more time on the implementation for the (Sync)ElegantOTA server side.

@ayushsharma82
Copy link
Owner

Interesting! We don't use the Update class directly in this library ( unlike AsyncElegantOTA ), Therefore it would be better not to spend any time rewriting the core routines from the ground up.

Let's keep the MD5 check for the AsyncElegantOTA for the time being. It's a nice addition though.

@qistoph
Copy link
Contributor Author

qistoph commented Jul 26, 2020

I'll try to work out a PR for the Update class to see if they're willing to include (optional) support for MD5 there 🙂

ui/src/App.vue Outdated Show resolved Hide resolved
@ayushsharma82 ayushsharma82 merged commit edf94a2 into ayushsharma82:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants