Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion body text turns white when embedded on background color #1443

Closed
danahertzberg opened this issue Mar 31, 2022 · 3 comments · Fixed by #1624
Closed

Accordion body text turns white when embedded on background color #1443

danahertzberg opened this issue Mar 31, 2022 · 3 comments · Fixed by #1624
Assignees
Labels
bug Something isn't working

Comments

@danahertzberg
Copy link
Contributor

danahertzberg commented Mar 31, 2022

Problem/Motivation

I want to embed a flexible block with accordions in a Text with background paragraph type

Describe the bug

Color is not set in CSS

To Reproduce

  1. Make a flexible block with accordion content
  2. Embed block in Text with background paragraph type

Proposed resolution

Add color: initial; to _card.scss file under .card, .panel, .thumbnail, .well {} group

Updated as of 2022/06/01:
This will become a two-part fix: a change to Bootstrap, and a change to Quickstart's Accordion.

Order does not matter here; adding the .bg-white class to the Accordion div will allow it to leverage the built-in color contrast fallbacks.

Expected behavior

Accordion body text should match standard body color (since it's on a white background)

Screenshots

Before

image

After

image

@danahertzberg danahertzberg added bug Something isn't working high priority Must get done for this milestone labels Mar 31, 2022
@danahertzberg
Copy link
Contributor Author

danahertzberg commented Apr 4, 2022

  • Test potential solution with wysiwyg editor color override.
  • Look into modifying default color when background is set to white.

@danahertzberg danahertzberg added low priority Nice to have for this milestone, can be pushed out if needed and removed high priority Must get done for this milestone labels Apr 6, 2022
@aslaymoore
Copy link
Contributor

aslaymoore commented Apr 6, 2022

The built-in color contrast in the Bootstrap SCSS is to blame for this one. It sees the .bg-blue (for example) and wants to turn the text white to keep it accessible, and doesn't realize that the accordion also has a white background already, since it doesn't have a .bg-* class applied to it.

If we were to add .bg-white to the accordion body


it should basically "reset" that so it's defaulting to use black text instead of white.

@aslaymoore
Copy link
Contributor

aslaymoore commented Jun 1, 2022

Since this issue will require a change to arizona-bootstrap rather than az_quickstart, I am moving this issue over to the Arizona Bootstrap repo: az-digital/arizona-bootstrap#489 .

This Quickstart issue should instead be modified to include the addition of the .bg-white class to the Accordion's collapse/.card-body section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants