android: Add static color theme option #350

kleidis · 2024-08-12T15:54:21Z

This PR adds a new option on the Theme section with a list of pre-set colors

This might be useful for people stuck on Android 11 or earlier version of android and people who don't want to use Material You for whatever reason

What is left to do

Set proper theme color hex values
The ones i added are just generated placeholders and some of them don't look good at all
( help is needed for this as i am not sure how to approach this)
Test the new changes, especially on older Android versions
I only had the chance to test on Android 14 and a virtual Android 11 device. More testing is needed

Video showcase:

Settings:

Screen_Recording_20240812_173851_Lime3DS.mp4

colors: Fix names for the blue theme strings: Update stirngs and names to actually lol

It is needed because the black theme was having issues needing a app retsart for the activity to fully chnage colors

The hex codes were quickly generated so some of them look awful and i'm not sure how to go about on fixing them

Now the pop up has 2 steps 1 - Asking you for the preferred static theme color you would want 2 - Asking you if you want to enable material you / black backgrounds Than it recreates the activity if the user hits ok Also had to tweak the listener on ThemeUtil for this chnage

BlurrySquire · 2024-08-12T18:00:37Z

Set proper theme color hex values

The ones i added are just generated placeholders and some of them don't look good at all
( help is needed for this as i am not sure how to approach this)

Testing before this has been implemented. The current themes work fine and don't bug out even when rapidly swapping between them. Also the Lime Green theme actually looks pretty good currently. I tested on Android 14.

I ended up removing Indigo, as it was too similar to Blue Also removed some useless duplicates

kleidis · 2024-08-13T11:34:21Z

I ended up just copying the tone of default blue theme for all new themes i added, it results on a bit more of muted tone for the themes in dark mode.

I also tested the feature more on a virtual A11 device and it seems to work fine on my end

Now the PR is ready for review

BlurrySquire

Everything works fine. I can switch between themes without lag or crashes. The theme menu on the config screen also works well. The code is also well-implemented.

kleidis · 2024-08-14T15:39:37Z

There is a bug i missed

If the user updates from a previous version, the listener of ThemeUtil.kt never gets called meaning theme switching gets broken

Good one

You can also get the same effect by skipping the theme setup menu

kleidis · 2024-08-16T20:01:42Z

Fixed that

Nothing left to do as far as I'm concerned

src/android/app/src/main/java/io/github/lime3ds/android/features/settings/model/Settings.kt

src/android/app/src/main/java/io/github/lime3ds/android/utils/ThemeUtil.kt

Co-authored-by: Gamer64 <[email protected]>

src/android/app/src/main/res/values/arrays.xml

OpenSauce04 · 2024-08-20T17:27:14Z

Upon testing this PR, I've realized that this code appears to cause an instant crash on Android 9. I will continue to investigate the issue.

kleidis · 2024-08-20T17:36:37Z

Upon testing this PR, I've realized that this code appears to cause an instant crash on Android 9. I will continue to investigate the issue.

I could spin up an Android 9 virtual device , weird that it even crashes in the first place

OpenSauce04 · 2024-08-20T17:47:01Z

Fixed it, it was caused by a typo.
You may want to push that fix to Mandarine, as they seemed to merge in a hurry.

kleidis · 2024-08-20T17:56:17Z

Fixed it, it was caused by a typo.
You may want to push that fix to Mandarine, as they seemed to merge in a hurry.

Ah fucking classic by me, sorry
Ill tell the G to merge it as well

OpenSauce04 · 2024-08-20T18:05:44Z

The Lime theme doesn't seem to be very... Lime.
It's nearly identical to the Green theme, just slightly more yellow.
Given that it's so similar to an existing theme and the name kind of stands out in the list of primary colours, should we just drop it?

OpenSauce04

Code looks good to me outside of the prior comment.
Outstanding license header warnings are to be ignored.

kleidis · 2024-08-20T18:50:07Z

The Lime theme doesn't seem to be very... Lime.
It's nearly identical to the Green theme, just slightly more yellow.
Given that it's so similar to an existing theme and the name kind of stands out in the list of primary colours, should we just drop it?

White or Dark Mode?

OpenSauce04 · 2024-08-20T18:51:13Z

White or Dark Mode?

I tested using Dark Mode

OpenSauce04 · 2024-08-20T18:52:56Z

Actually now that I look at it again, the Green theme seems to be a little more blue than you would expect?

I would perhaps suggest dropping the Green theme and renaming the Lime theme to Green to replace it.

kleidis · 2024-08-20T18:53:11Z

White or Dark Mode?

I tested using Dark Mode

On white mode, the difference is more noticitable, at least on my screen

But yeah, on dark mode, i feel like it's almost tue same

You can try to tweak the hex values of the dark lime theme, but if it ends up looking bad , just drop it.

kleidis · 2024-08-20T18:56:13Z

Actually now that I look at it again, the Green theme seems to be a little more blue than you would expect?

I would perhaps suggest dropping the Green theme and renaming the Lime theme to Green to replace it.

Ok, then I'll do it tomorrow

OpenSauce04 · 2024-08-20T18:58:39Z

Ok, then I'll do it tomorrow

No need, I'll do it now. Just wanted your confirmation

OpenSauce04 · 2024-08-20T19:17:38Z

Oops, meant to rebase the branch, not rebase and merge. 😜
Code was ready anyway, was just about to merge manually.

kleidis added 6 commits August 11, 2024 18:41

[wip] android: Add static color theme support

3e4b6cf

colors: Fix names for the blue theme strings: Update stirngs and names to actually lol

theme_util: Add a listener to recreate activity once color is changed

f8ea10b

It is needed because the black theme was having issues needing a app retsart for the activity to fully chnage colors

theme_util: Recreate activity when MY is toggled too

95a928d

setup: Add new page for theme settings selection

236db9a

[very wip] colors: Add more colors

25fde6a

The hex codes were quickly generated so some of them look awful and i'm not sure how to go about on fixing them

pull-request-size bot added the size/XXL label Aug 12, 2024

OpenSauce04 added this to the 2118 milestone Aug 12, 2024

OpenSauce04 added the enhancement New feature or request label Aug 12, 2024

BlurrySquire self-requested a review August 12, 2024 17:57

BlurrySquire removed their request for review August 12, 2024 18:00

citra_colors: Fix the colors for all themes

f6c20c9

I ended up removing Indigo, as it was too similar to Blue Also removed some useless duplicates

kleidis marked this pull request as ready for review August 13, 2024 11:36

kleidis changed the title ~~android: Add static color theme option support~~ android: Add static color theme option & new setup page for theming Aug 13, 2024

BlurrySquire self-requested a review August 13, 2024 21:53

BlurrySquire approved these changes Aug 13, 2024

View reviewed changes

kleidis added 2 commits August 16, 2024 14:51

listener: Make it a global value && cleanup

d71603b

setup: more code cleanup

be93b4d

Gamer64ytb reviewed Aug 16, 2024

View reviewed changes

src/android/app/src/main/java/io/github/lime3ds/android/features/settings/model/Settings.kt Outdated Show resolved Hide resolved

Gamer64ytb reviewed Aug 16, 2024

View reviewed changes

src/android/app/src/main/java/io/github/lime3ds/android/utils/ThemeUtil.kt Outdated Show resolved Hide resolved

kleidis requested a review from OpenSauce04 August 17, 2024 07:44

OpenSauce04 and others added 2 commits August 17, 2024 19:02

Updated PREF_STATIC_THEME_COLOR string to follow convention

c0a188a

Co-authored-by: Gamer64 <[email protected]>

Comment spelling correction + Nitpick formatting

a7c5169

Co-authored-by: Gamer64 <[email protected]>

OpenSauce04 added the squash This pull request should be squashed if approved label Aug 17, 2024

Nitpicky code formatting tweaks

5fd8d3a

OpenSauce04 requested changes Aug 17, 2024

View reviewed changes

src/android/app/src/main/res/values/arrays.xml Outdated Show resolved Hide resolved

themeutil: Update listener comment

e74a8ef

kleidis changed the title ~~android: Add static color theme option & new setup page for theming~~ android: Add static color theme option Aug 19, 2024

OpenSauce04 self-requested a review August 20, 2024 16:44

Fixed instant crash on Android 9

1dd9168

Theme.Citra --> Theme.Lime

c442da0

Renamed all "citra_" color prefixes to "lime_"

a27df41

pull-request-size bot added size/XXL and removed size/XL labels Aug 20, 2024

Reverted unwarranted license header changes

43e5c64

OpenSauce04 approved these changes Aug 20, 2024

View reviewed changes

Removed Lime theme gave its values to the Green theme

215ab66

pull-request-size bot added size/XL and removed size/XXL labels Aug 20, 2024

OpenSauce04 merged commit c2462e4 into azahar-emu:master Aug 20, 2024
9 of 10 checks passed

OpenSauce04 added manual merge and removed squash This pull request should be squashed if approved labels Aug 20, 2024

kleidis mentioned this pull request Sep 17, 2024

Cleanup Theme Colors #445

Closed

kleidis deleted the material-me branch October 14, 2024 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

android: Add static color theme option #350

android: Add static color theme option #350

kleidis commented Aug 12, 2024 •

edited

Loading

BlurrySquire commented Aug 12, 2024

kleidis commented Aug 13, 2024

BlurrySquire left a comment

kleidis commented Aug 14, 2024 •

edited

Loading

kleidis commented Aug 16, 2024

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

kleidis commented Aug 20, 2024 •

edited

Loading

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

kleidis commented Aug 20, 2024 •

edited

Loading

OpenSauce04 commented Aug 20, 2024

OpenSauce04 left a comment •

edited

Loading

kleidis commented Aug 20, 2024

OpenSauce04 commented Aug 20, 2024

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

kleidis commented Aug 20, 2024

kleidis commented Aug 20, 2024

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

android: Add static color theme option #350

android: Add static color theme option #350

Conversation

kleidis commented Aug 12, 2024 • edited Loading

BlurrySquire commented Aug 12, 2024

kleidis commented Aug 13, 2024

BlurrySquire left a comment

Choose a reason for hiding this comment

kleidis commented Aug 14, 2024 • edited Loading

kleidis commented Aug 16, 2024

OpenSauce04 commented Aug 20, 2024 • edited Loading

kleidis commented Aug 20, 2024 • edited Loading

OpenSauce04 commented Aug 20, 2024 • edited Loading

kleidis commented Aug 20, 2024 • edited Loading

OpenSauce04 commented Aug 20, 2024

OpenSauce04 left a comment • edited Loading

Choose a reason for hiding this comment

kleidis commented Aug 20, 2024

OpenSauce04 commented Aug 20, 2024

OpenSauce04 commented Aug 20, 2024 • edited Loading

kleidis commented Aug 20, 2024

kleidis commented Aug 20, 2024

OpenSauce04 commented Aug 20, 2024 • edited Loading

OpenSauce04 commented Aug 20, 2024 • edited Loading

kleidis commented Aug 12, 2024 •

edited

Loading

kleidis commented Aug 14, 2024 •

edited

Loading

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

kleidis commented Aug 20, 2024 •

edited

Loading

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

kleidis commented Aug 20, 2024 •

edited

Loading

OpenSauce04 left a comment •

edited

Loading

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

OpenSauce04 commented Aug 20, 2024 •

edited

Loading

OpenSauce04 commented Aug 20, 2024 •

edited

Loading