Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swapping screens on landscape displays forcing portrait layout V2 #390

Merged

Conversation

OpenSauce04
Copy link
Member

Supersedes #389
Closes #387

The functionality of this code should be identical to the original PR.

This code requires testing to verify that the issue has been resolved. As of opening this I am currently a little busy, however I will test this myself later today if nobody else does so first.

@OpenSauce04 OpenSauce04 added bug Something isn't working and removed size/S labels Aug 23, 2024
@OpenSauce04 OpenSauce04 added this to the 2118 milestone Aug 23, 2024
@OpenSauce04 OpenSauce04 changed the title Fixed swapping screens on landscape displays forcing portrait layout v2 Fix swapping screens on landscape displays forcing portrait layout V2 Aug 23, 2024
@DavidRGriswold
Copy link
Collaborator

I like this solution, an android-universally imported util.h could potentially be used for other things.

It's taking a weirdly long time to download on my work WiFi but I'll test it out soon.

@DavidRGriswold
Copy link
Collaborator

Tested, seems to work fine. Fiddled around with all the display settings in landscape and portrait both with my regular screen size and one set to false landscape-on-portrait values and it seems to do what it should.

@OpenSauce04 OpenSauce04 merged commit 8af024b into azahar-emu:master Aug 23, 2024
12 checks passed
@OpenSauce04 OpenSauce04 deleted the fix-landscape-screen-swap branch August 23, 2024 14:31
@rtiangha rtiangha mentioned this pull request Sep 2, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swapping screens while in Landscape Mode forces Portrait layout (and vice versa)
2 participants