Added Java Conditional check #20
Conversation
Check to see if we need to install java.
Added `spark_install_java: True` to allow java to be conditionally installed
Add spark commands to path
Variable to see if the path should be added.
Check to see if the bin directory needs to be added to the path
There was a problem hiding this comment.
This looks good to me; thank you and congrats on your first contribution! 🎉 @darkedges would you mind rebasing this into 2 commits: one to add the JAVA check, and one for creating /etc/profile.d/spark.sh? Thanks!
| @@ -13,4 +13,4 @@ galaxy_info: | |||
| categories: | |||
| - system | |||
| dependencies: | |||
| - { role: "azavea.java" } | |||
| - { role: "azavea.java", when: spark_install_java } | |||
There was a problem hiding this comment.
awesome 👍 ( somehow didn't come to this idea, that when works here!)
This fix could also allow us to re-align our fork (in which I just removed the whole dependency)
There was a problem hiding this comment.
@tnation14 I'm motivated to get half of this PR with the spark_install_java part merged (essentially the first 3 commits), or the full changes ok too.
As I don't have committer perms here... I've done #26
|
very much useful also for us 👍 |
|
Since #26 has been merged this PR needs to be rebased, keeping only the profile/spark.sh related changes.. and if those aren't required anymore, PR can be closed |
I had already deployed Java and so added a conditional check on the
meta\main.ymlto allow me to override the installation of Java. By default it will install and the variablespark_install_javamust be overridden to stop the installation.