Skip to content

Commit

Permalink
fix(DB/Misc): Bad delete in update file (#21307)
Browse files Browse the repository at this point in the history
Co-authored-by: Andrew <[email protected]>
  • Loading branch information
Kitzunu and Nyeriah authored Feb 1, 2025
1 parent 5e7d4bd commit 1373376
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 6 additions & 0 deletions apps/codestyle/codestyle-sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,16 @@ def trailing_whitespace_check(file: io, file_path: str) -> None:
def sql_check(file: io, file_path: str) -> None:
global error_handler, results
file.seek(0) # Reset file pointer to the beginning
not_delete = ["creature_template", "gameobject_template", "item_template", "quest_template"]
check_failed = False

# Parse all the file
for line_number, line in enumerate(file, start = 1):
for table in not_delete:
if f"DELETE FROM `{table}`" in line:
print(
f"Entries from this {table} should not be deleted! {file_path} at line {line_number}")
check_failed = True
if [match for match in ['broadcast_text'] if match in line]:
print(
f"DON'T EDIT broadcast_text TABLE UNLESS YOU KNOW WHAT YOU ARE DOING!\nThis error can safely be ignored if the changes are approved to be sniffed: {file_path} at line {line_number}")
Expand Down
1 change: 0 additions & 1 deletion data/sql/updates/db_world/2025_01_31_01.sql
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
-- DB update 2025_01_31_00 -> 2025_01_31_01
-- Add pure energy immune script for Vex
DELETE FROM `creature_template` WHERE `ScriptName` = 'npc_pure_energy' AND entry = 24745;
UPDATE `creature_template` SET `ScriptName` = 'npc_pure_energy' WHERE (`entry` = 24745);

-- AOE_IMMUNE Flag for pure energy
Expand Down

0 comments on commit 1373376

Please sign in to comment.