chore(bash/docker): Docker installation support for ARM64 machines

[podmepodme]

Before this change, ./acore.sh docker build failed on ARM MacBook.
With url updated, i was able to run AzerothCore from docker and successfully logged in to game.

This is repo from which url was taken: https://github.com/LukeChannings/deno-arm64

Changes Proposed:

• replaced deno_install.sh link for one which also include arm version

Issues Addressed:

• Already closed but not implemented
• Closes ./acore.sh docker client-data failed on macbook m1 #10851

SOURCE:

Tests Performed:

• Running ./acore.sh docker build will result in following error:

Sorry for screenshot, i don't know how to format output properly.
Test was performed on MacBook Pro 14 M1 running Ventura 13.4.1 (c)

How to Test the Changes:

1. in repo: ./acore.sh docker build

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Kitzunu]

As there is no active docker developer I will leave this open in hopes someone wants to test it.

Worst case I will just merge it and if it were to break something we can just revert it.

[walkline]

I wouldn't recommend using someone's personal gist as a default dependency option. Perhaps consider using this gist as a fallback option for only arm64 platform instead?

But in general JS runtime dependency to build a C++ project looks weird to me 😁

[michaeldelago]

Whats the licensing on the gist link? We should vendor it in the repo if we intend to use it, rather than referring to it like that.

[EDIT]

Thinking on this a bit further, Deno doesn't officially support ARM64 and I think it'd make sense to remove the dependency on Deno in the docker containers rather than use an unofficial version of Deno. IMO, Deno in the containers creates more problems than it solves.

I can probably whip up a PR for this sometime this week.

[podmepodme]

I like the idea of including script in the repo. however i I couldn't find license in deno-arm64 repo. I will contact the author about this.

Maybe we could get rid of deno altogether, but for now it will be easier just to include the script.

[podmepodme]

Author specified license in the script (MIT).

Can i include this script (and edit apps/bash_shared/deno.sh accordingly ) in next commit for this PR? Sorry for asking trivial questions, this is my first PR in open-source project.

[podmepodme]

@michaeldelago did a great job in PR #16898, which removes deno as a dependency from the docker build. As far as I know, this dependency is the only reason why AzerothCore did not build on the arm machines from Docker. Because of that, I am closing this PR.