fix(Scripts/ICC/Sindragosa) Airphase should not be forced after 50s if already in p2 (under 35%)

[qwe900]

Sindragosa skips her Airphase if she reaches 35%, Airphase istn forced after 50s.
https://youtu.be/U3dn89QhTy8?t=502

We did this on Retail with 1 Tank 8DDs 1 Heal in 10HC to force the boss to stay on ground.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

Debian 11

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

Fight Sindra and do damage to 35% in under 50s

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[kjack9]

After reviewing the video evidence, I can confirm that Sindragosa does not take to the air if lowered to 35% before her first flight.

In the video, the player takes 35 seconds to take the boss from 100% to 35%. Although the boss mod in use does announce "Phase 2" at the 50 second mark, she does not enter her flight phase before her death at 54 seconds.

The mandatory flight phase enforced with _didFirstFlyPhase appears to be incorrect and should be removed. It additionally prevents the weekly quest trigger in DamageTaken from being triggered if the boss is killed too quickly.

[elthehablo]

Fix title to conform to our standards, please. This is important to be able to more easily search for things in the future

[elthehablo]

Thank you