Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Scripts/SSC): Script Hydross OOC event #17804

Merged
merged 4 commits into from
Nov 20, 2023
Merged

fix(Scripts/SSC): Script Hydross OOC event #17804

merged 4 commits into from
Nov 20, 2023

Conversation

Nyeriah
Copy link
Member

@Nyeriah Nyeriah commented Nov 20, 2023 •
edited
Loading

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added DB related to the SQL database CORE Related to the core Script file-cpp Used to trigger the matrix build labels Nov 20, 2023
@PkllonG
Copy link
Contributor

PkllonG commented Nov 20, 2023

good
image

@elthehablo elthehablo merged commit 7795dc4 into azerothcore:master Nov 20, 2023
@Nyeriah Nyeriah deleted the hydrosss branch November 20, 2023 09:57
james-huston pushed a commit to araxiaonline/AzerothCore-wotlk-with-NPCBots that referenced this pull request Jun 13, 2024
@Nyeriah
fix(Scripts/SSC): Script Hydross OOC event (azerothcore#17804)
ba5985a 
* fix(Scripts/SSC): Script Hydross OOC event

* Update rev_1700448248255858600.sql

* Update boss_hydross_the_unstable.cpp

* Update rev_1700448248255858600.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elthehablo elthehablo elthehablo approved these changes

Assignees
No one assigned
Labels
CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Ready to be Reviewed Script To Be Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyeriah @PkllonG @elthehablo