Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Loot) Clean up loot of bosses in MGT HC #21262

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

Tereneckla
Copy link
Contributor

@Tereneckla Tereneckla commented Jan 24, 2025

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Remove Normal loot from all HC Bosses
Group items of Kael'thas

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Counting drops in multiple videos
image

https://youtu.be/vRjgCtDOzo8
https://youtu.be/eps9m8S4cLc
https://youtu.be/nKSSYAkpW_s
https://youtu.be/o1FaN1_JIug
https://youtu.be/4ZHh5UhkGIE
https://youtu.be/My5ZrCZ8mok
https://youtu.be/L-eWJ_TdMSE
https://youtu.be/g5oA9_0s8CY
https://youtu.be/kVF_Di5CRKo
https://youtu.be/xkJysd5YOHI
https://youtu.be/C7nMa-cM4pI
https://youtu.be/13EsTeJmiPQ
https://youtu.be/kfZoZ5EVNCo
https://youtu.be/AN27RLSZXu4
https://youtu.be/eFILcvIVrEo
https://youtu.be/9MierCOmCmA
https://youtu.be/sQFQbzAk-7s
https://youtu.be/GJcy8cK0d10
https://youtu.be/CTddhJ9g5Lk

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
sohkai Brett Sun
@Tereneckla Tereneckla added Loot Loot related issues 70 TBC endgame content labels Jan 24, 2025
@github-actions github-actions bot added the DB related to the SQL database label Jan 24, 2025
...
@Rorschach91 Rorschach91 merged commit c54de87 into azerothcore:master Jan 24, 2025
12 checks passed
@Tereneckla Tereneckla deleted the mgt-loot branch January 24, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
70 TBC endgame content DB related to the SQL database Loot Loot related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Magister's Terrace] All bosses in heroic drops their normal loot
2 participants