Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts/Felmyst): Adjust beam target #4055

Merged
merged 1 commit into from
Dec 26, 2020
Merged

fix(scripts/Felmyst): Adjust beam target #4055

merged 1 commit into from
Dec 26, 2020

Conversation

Si1ker
Copy link
Contributor

@Si1ker Si1ker commented Dec 26, 2020

Change the way Felmyst selects the target for the beam which summons skeletons at the encounter.

All available players get one beam ❌
Only one player gets one beam ✔️

Sources:

Changes Proposed:

  • Convert CastSpell to CastCustomSpell in order to prevent AOE targets and just pick one valid target

Issues Addressed:

  • Felmyst currently summons one beam per player available in the encounter instead of pick just one as the expected blizzlike behavior

Tests Performed:

  • Tested in-game locally and with a production/live server in the past.
    image

How to Test the Changes:

You will need to bring 2 accounts and make a raid group
.go c felmyst
Kill Brutallus
Wait for >1 minute until Felmyst spawns
Engage Felmyst and wait for her Phase 2 -> She will target only 1 of your 2 characters as the blizzlike behavior.

Known Issues and TODO List:

  • N/A

Target Branch(es):

  • Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

@Si1ker Si1ker merged commit 3654c18 into azerothcore:master Dec 26, 2020
@Si1ker Si1ker deleted the felmyst-beam branch December 26, 2020 18:56
@BarbzYHOOL
Copy link
Member

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants