Add new hook OnPlayerQueueRandomDungeon() and revert (now unnecessary) PR #8196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoBorzi
changed the title
| @@ -841,6 +841,9 @@ class PlayerScript : public ScriptObject | |||
| // Called when a player is added to battleground | |||
| virtual void OnAddToBattleground(Player* /*player*/, Battleground* /*bg*/) { } | |||
|
|
|||
| // Called when a player queues a Random Dungeon using the RDF (Random Dungeon Finder) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
sorry I missed this, I'll address this in another PR
|
Well I tested this mod and it not works as it should nor I do something wrong.
|
|
@nolt not sure if you noticed but in the module it mentions about the client limitation. Even though it displays the random tbc or wotlk dungeons, if you actually queue up it will only place you into the dungeons for the enabled expansion. I ran tests and queued up several times and looks to be working as expected. I only ever got put into a dungeon for the expansion that was enabled. |
locus313
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
OnPlayerQueueRandomDungeon()Tests Performed:
How to Test the Changes:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.