Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get msiResource for multi sub #351

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix get msiResource for multi sub #351

merged 1 commit into from
Nov 6, 2023

Conversation

enricobtn
Copy link
Contributor

Add tfstate_subscription_id parameter to az identity list when setting msiResource from assignedIdentityInfo

Fixes the following issue
#350

@arnaudlh arnaudlh linked an issue Nov 6, 2023 that may be closed by this pull request
Rover fails to set msi object_id when using user assigned identity for multi subscription deployment #350
Closed
@arnaudlh arnaudlh added the bug Something isn't working label Nov 6, 2023
arnaudlh
arnaudlh approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit 8603743 into aztfmod:main Nov 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@enricobtn enricobtn

Labels
bug Something isn't working
Projects
No open projects
2311
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rover fails to set msi object_id when using user assigned identity for multi subscription deployment
2 participants
@enricobtn @arnaudlh