Update dependencies. Replace JSHint with ESLint. Remove grunt #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
commented
Sep 1, 2019
| @@ -202,9 +202,10 @@ describe("yolo", function () { | |||
|
|
|||
| var onReadable = function () { | |||
| // Readable is emitted as soon a row is received and parsed | |||
| var row; | |||
| while (row = this.read()) { | |||
| var row = this.read(); | |||
There was a problem hiding this comment.
ESLint is unhappy about assignment within condition.
kibertoad
commented
Sep 1, 2019
| @@ -103,6 +103,7 @@ function _getSelect() { | |||
| if (_.has(this._grouped, "aggregate")) { | |||
| _.each(this._grouped.aggregate, function (aggregate) { | |||
| // TODO add.. more.. aggregates | |||
| var key, val; | |||
There was a problem hiding this comment.
ESLint is unhappy about redefining previously defined key, val variables, hence I extracted definition to a common scope.
|
@UnbounDev Would you consider taking a look? |
austinbrown-okta
approved these changes
Dec 29, 2019
There was a problem hiding this comment.
LGTM, thanks for the contribution @kibertoad and apologies that it slipped my notice for so long!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Grunt is pretty much considered legacy now, I've replaced it with direct npm script invocation.
Same with JSHint - ESLint is up-to-date alternative.