Merge pull request #3314 from Azure/gopremra/FixICUBuildIssues

Fix ICU build issues
azure-sdk · Jan 28, 2025 · f9eb27c · f9eb27c
2 parents 45208a0 + ccdeaf8
commit f9eb27c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/.github/workflows/generate-schemas.yml b/.github/workflows/generate-schemas.yml
@@ -17,7 +17,7 @@ env:
 jobs:
   generate:
     name: Update Schemas Batch ${{ matrix.batch }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04 #Pinning the image to a specific version due to an issue with ICU packages in the latest image https://github.com/actions/runner-images/issues/10989
     strategy:
       fail-fast: false
       matrix:
@@ -94,7 +94,7 @@ jobs:
     name: Combine Schema Batches
     permissions:
       contents: write
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04 #Pinning the image to a specific version due to an issue with ICU packages in the latest image https://github.com/actions/runner-images/issues/10989
     steps:
       - name: Checkout repo
         uses: actions/checkout@v4

diff --git a/.github/workflows/generate-single.yml b/.github/workflows/generate-single.yml
@@ -16,7 +16,7 @@ jobs:
     name: Update Schemas
     permissions:
       contents: write
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04 #Pinning the image to a specific version due to an issue with ICU packages in the latest image https://github.com/actions/runner-images/issues/10989
 
     steps:
       - name: Checkout repo

diff --git a/generator/autogenlist.ts b/generator/autogenlist.ts
@@ -170,7 +170,7 @@ const autoGenList: AutoGenConfig[] = [
         namespace: 'Microsoft.Automation',
     },
     {
-        basePath: 'awsConnector/resource-manager',
+        basePath: 'awsconnector/resource-manager',
         namespace: 'Microsoft.AwsConnector',
         postProcessor: awsConnectorPostProcessor
     },

diff --git a/generator/utils.ts b/generator/utils.ts
@@ -14,11 +14,7 @@ export function executeCmd(cwd: string, cmd: string, args: string[]) : Promise<n
         const child = spawn(cmd, args, {
             cwd: cwd,
             windowsHide: true,
-            env: {
-              ...process.env,
-              // needed to workaround dotnet globalization issues in autorest .NET plugins
-              DOTNET_SYSTEM_GLOBALIZATION_INVARIANT: '1',
-            },
+            shell: true,
         });
 
         child.stdout.on('data', data => process.stdout.write(colors.grey(data.toString())));