[AutoPR azure-resourcemanager-paloaltonetworks-ngfw] [Hub Generated] Review request for PaloAltoNetworks.Cloudngfw to add version preview/2023-09-01-preview

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/CHANGELOG.md

@@ -1,6 +1,8 @@
 # Release History
 
-## 1.1.0-beta.1 (Unreleased)
+## 1.0.0-beta.1 (2023-10-16)
+
+- Azure Resource Manager PaloAlto Networks Ngfw client library for Java. This package contains Microsoft Azure SDK for PaloAlto Networks Ngfw Management SDK.  Package tag package-2023-09-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).
 
 ### Features Added
 

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/README.md

@@ -2,7 +2,7 @@
 
 Azure Resource Manager PaloAlto Networks Ngfw client library for Java.
 
-This package contains Microsoft Azure SDK for PaloAlto Networks Ngfw Management SDK.  Package tag package-2022-08-29. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).
+This package contains Microsoft Azure SDK for PaloAlto Networks Ngfw Management SDK.  Package tag package-2023-09-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).
 
 ## We'd love to hear your feedback
 
@@ -32,7 +32,7 @@ Various documentation is available to help you get started
 <dependency>
     <groupId>com.azure.resourcemanager</groupId>
     <artifactId>azure-resourcemanager-paloaltonetworks-ngfw</artifactId>
-    <version>1.0.0</version>
+    <version>1.1.0-beta.1</version>
 </dependency>
 ```
 [//]: # ({x-version-update-end})
@@ -103,3 +103,5 @@ This project has adopted the [Microsoft Open Source Code of Conduct][coc]. For m
 [cg]: https://github.com/Azure/azure-sdk-for-java/blob/main/CONTRIBUTING.md
 [coc]: https://opensource.microsoft.com/codeofconduct/
 [coc_faq]: https://opensource.microsoft.com/codeofconduct/faq/
+
+![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-java%2Fsdk%2Fpaloaltonetworks%2Fazure-resourcemanager-paloaltonetworks-ngfw%2FREADME.png)

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/pom.xml

@@ -18,7 +18,7 @@
   <packaging>jar</packaging>
 
   <name>Microsoft Azure SDK for PaloAlto Networks Ngfw Management</name>
-  <description>This package contains Microsoft Azure SDK for PaloAlto Networks Ngfw Management SDK. For documentation on how to use this package, please see https://aka.ms/azsdk/java/mgmt.  Package tag package-2022-08-29.</description>
+  <description>This package contains Microsoft Azure SDK for PaloAlto Networks Ngfw Management SDK. For documentation on how to use this package, please see https://aka.ms/azsdk/java/mgmt.  Package tag package-2023-09-01.</description>
   <url>https://github.com/Azure/azure-sdk-for-java</url>
 
   <licenses>
@@ -45,6 +45,7 @@
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <jacoco.min.linecoverage>0</jacoco.min.linecoverage>
     <jacoco.min.branchcoverage>0</jacoco.min.branchcoverage>
+    <revapi.skip>true</revapi.skip>
   </properties>
   <dependencies>
     <dependency>

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/src/main/java/com/azure/resourcemanager/paloaltonetworks/ngfw/PaloAltoNetworksNgfwManager.java

@@ -255,7 +255,7 @@ public PaloAltoNetworksNgfwManager authenticate(TokenCredential credential, Azur
                 .append("-")
                 .append("com.azure.resourcemanager.paloaltonetworks.ngfw")
                 .append("/")
-                .append("1.0.0");
+                .append("1.0.0-beta.1");
             if (!Configuration.getGlobalConfiguration().get("AZURE_TELEMETRY_DISABLED", false)) {
                 userAgentBuilder
                     .append(" (")
@@ -488,8 +488,10 @@ public PrefixListLocalRulestacks prefixListLocalRulestacks() {
     }
 
     /**
-     * @return Wrapped service client PaloAltoNetworksCloudngfw providing direct access to the underlying auto-generated
-     *     API implementation, based on Azure REST API.
+     * Gets wrapped service client PaloAltoNetworksCloudngfw providing direct access to the underlying auto-generated
+     * API implementation, based on Azure REST API.
+     *
+     * @return Wrapped service client PaloAltoNetworksCloudngfw.
      */
     public PaloAltoNetworksCloudngfw serviceClient() {
         return this.clientObject;

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/src/main/java/com/azure/resourcemanager/paloaltonetworks/ngfw/fluent/LocalRulestacksClient.java

@@ -13,11 +13,8 @@
 import com.azure.core.util.polling.SyncPoller;
 import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.AdvSecurityObjectListResponseInner;
 import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.ChangelogInner;
-import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.CountriesResponseInner;
-import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.ListAppIdResponseInner;
 import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.ListFirewallsResponseInner;
 import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.LocalRulestackResourceInner;
-import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.PredefinedUrlCategoriesResponseInner;
 import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.SecurityServicesResponseInner;
 import com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models.SupportInfoInner;
 import com.azure.resourcemanager.paloaltonetworks.ngfw.models.AdvSecurityObjectTypeEnum;
@@ -395,74 +392,6 @@ Response<AdvSecurityObjectListResponseInner> listAdvancedSecurityObjectsWithResp
     AdvSecurityObjectListResponseInner listAdvancedSecurityObjects(
         String resourceGroupName, String localRulestackName, AdvSecurityObjectTypeEnum type);
 
-    /**
-     * List of AppIds for LocalRulestack ApiVersion.
-     *
-     * @param resourceGroupName The name of the resource group. The name is case insensitive.
-     * @param localRulestackName LocalRulestack resource name.
-     * @param appIdVersion The appIdVersion parameter.
-     * @param appPrefix The appPrefix parameter.
-     * @param skip The skip parameter.
-     * @param top The top parameter.
-     * @param context The context to associate with this operation.
-     * @throws IllegalArgumentException thrown if parameters fail the validation.
-     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
-     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return the response body along with {@link Response}.
-     */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    Response<ListAppIdResponseInner> listAppIdsWithResponse(
-        String resourceGroupName,
-        String localRulestackName,
-        String appIdVersion,
-        String appPrefix,
-        String skip,
-        Integer top,
-        Context context);
-
-    /**
-     * List of AppIds for LocalRulestack ApiVersion.
-     *
-     * @param resourceGroupName The name of the resource group. The name is case insensitive.
-     * @param localRulestackName LocalRulestack resource name.
-     * @throws IllegalArgumentException thrown if parameters fail the validation.
-     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
-     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return the response.
-     */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    ListAppIdResponseInner listAppIds(String resourceGroupName, String localRulestackName);
-
-    /**
-     * List of countries for Rulestack.
-     *
-     * @param resourceGroupName The name of the resource group. The name is case insensitive.
-     * @param localRulestackName LocalRulestack resource name.
-     * @param skip The skip parameter.
-     * @param top The top parameter.
-     * @param context The context to associate with this operation.
-     * @throws IllegalArgumentException thrown if parameters fail the validation.
-     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
-     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return countries Response Object along with {@link Response}.
-     */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    Response<CountriesResponseInner> listCountriesWithResponse(
-        String resourceGroupName, String localRulestackName, String skip, Integer top, Context context);
-
-    /**
-     * List of countries for Rulestack.
-     *
-     * @param resourceGroupName The name of the resource group. The name is case insensitive.
-     * @param localRulestackName LocalRulestack resource name.
-     * @throws IllegalArgumentException thrown if parameters fail the validation.
-     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
-     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return countries Response Object.
-     */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    CountriesResponseInner listCountries(String resourceGroupName, String localRulestackName);
-
     /**
      * List of Firewalls associated with Rulestack.
      *
@@ -491,37 +420,6 @@ Response<ListFirewallsResponseInner> listFirewallsWithResponse(
     @ServiceMethod(returns = ReturnType.SINGLE)
     ListFirewallsResponseInner listFirewalls(String resourceGroupName, String localRulestackName);
 
-    /**
-     * List predefined URL categories for rulestack.
-     *
-     * @param resourceGroupName The name of the resource group. The name is case insensitive.
-     * @param localRulestackName LocalRulestack resource name.
-     * @param skip The skip parameter.
-     * @param top The top parameter.
-     * @param context The context to associate with this operation.
-     * @throws IllegalArgumentException thrown if parameters fail the validation.
-     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
-     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return predefined url categories response along with {@link Response}.
-     */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    Response<PredefinedUrlCategoriesResponseInner> listPredefinedUrlCategoriesWithResponse(
-        String resourceGroupName, String localRulestackName, String skip, Integer top, Context context);
-
-    /**
-     * List predefined URL categories for rulestack.
-     *
-     * @param resourceGroupName The name of the resource group. The name is case insensitive.
-     * @param localRulestackName LocalRulestack resource name.
-     * @throws IllegalArgumentException thrown if parameters fail the validation.
-     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
-     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return predefined url categories response.
-     */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    PredefinedUrlCategoriesResponseInner listPredefinedUrlCategories(
-        String resourceGroupName, String localRulestackName);
-
     /**
      * List the security services for rulestack.
      *

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/src/main/java/com/azure/resourcemanager/paloaltonetworks/ngfw/fluent/models/CountriesResponseInner.java

@@ -6,7 +6,6 @@
 
 import com.azure.core.annotation.Fluent;
 import com.azure.core.util.logging.ClientLogger;
-import com.azure.resourcemanager.paloaltonetworks.ngfw.models.Country;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import java.util.List;
 
@@ -17,7 +16,7 @@ public final class CountriesResponseInner {
      * List of countries
      */
     @JsonProperty(value = "value", required = true)
-    private List<Country> value;
+    private List<CountryInner> value;
 
     /*
      * next link
@@ -34,7 +33,7 @@ public CountriesResponseInner() {
      *
      * @return the value value.
      */
-    public List<Country> value() {
+    public List<CountryInner> value() {
         return this.value;
     }
 
@@ -44,7 +43,7 @@ public List<Country> value() {
      * @param value the value value to set.
      * @return the CountriesResponseInner object itself.
      */
-    public CountriesResponseInner withValue(List<Country> value) {
+    public CountriesResponseInner withValue(List<CountryInner> value) {
         this.value = value;
         return this;
     }

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/src/main/java/com/azure/resourcemanager/paloaltonetworks/ngfw/fluent/models/CountryInner.java

@@ -0,0 +1,84 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+// Code generated by Microsoft (R) AutoRest Code Generator.
+
+package com.azure.resourcemanager.paloaltonetworks.ngfw.fluent.models;
+
+import com.azure.core.annotation.Fluent;
+import com.azure.core.util.logging.ClientLogger;
+import com.fasterxml.jackson.annotation.JsonProperty;
+
+/** Country Description. */
+@Fluent
+public final class CountryInner {
+    /*
+     * country code
+     */
+    @JsonProperty(value = "code", required = true)
+    private String code;
+
+    /*
+     * code description
+     */
+    @JsonProperty(value = "description")
+    private String description;
+
+    /** Creates an instance of CountryInner class. */
+    public CountryInner() {
+    }
+
+    /**
+     * Get the code property: country code.
+     *
+     * @return the code value.
+     */
+    public String code() {
+        return this.code;
+    }
+
+    /**
+     * Set the code property: country code.
+     *
+     * @param code the code value to set.
+     * @return the CountryInner object itself.
+     */
+    public CountryInner withCode(String code) {
+        this.code = code;
+        return this;
+    }
+
+    /**
+     * Get the description property: code description.
+     *
+     * @return the description value.
+     */
+    public String description() {
+        return this.description;
+    }
+
+    /**
+     * Set the description property: code description.
+     *
+     * @param description the description value to set.
+     * @return the CountryInner object itself.
+     */
+    public CountryInner withDescription(String description) {
+        this.description = description;
+        return this;
+    }
+
+    /**
+     * Validates the instance.
+     *
+     * @throws IllegalArgumentException thrown if the instance is not valid.
+     */
+    public void validate() {
+        if (code() == null) {
+            throw LOGGER
+                .logExceptionAsError(
+                    new IllegalArgumentException("Missing required property code in model CountryInner"));
+        }
+    }
+
+    private static final ClientLogger LOGGER = new ClientLogger(CountryInner.class);
+}

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/src/main/java/com/azure/resourcemanager/paloaltonetworks/ngfw/fluent/models/PredefinedUrlCategoriesResponseInner.java

@@ -6,7 +6,6 @@
 
 import com.azure.core.annotation.Fluent;
 import com.azure.core.util.logging.ClientLogger;
-import com.azure.resourcemanager.paloaltonetworks.ngfw.models.PredefinedUrlCategory;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import java.util.List;
 
@@ -17,7 +16,7 @@ public final class PredefinedUrlCategoriesResponseInner {
      * predefined url categories
      */
     @JsonProperty(value = "value", required = true)
-    private List<PredefinedUrlCategory> value;
+    private List<PredefinedUrlCategoryInner> value;
 
     /*
      * next link
@@ -34,7 +33,7 @@ public PredefinedUrlCategoriesResponseInner() {
      *
      * @return the value value.
      */
-    public List<PredefinedUrlCategory> value() {
+    public List<PredefinedUrlCategoryInner> value() {
         return this.value;
     }
 
@@ -44,7 +43,7 @@ public List<PredefinedUrlCategory> value() {
      * @param value the value value to set.
      * @return the PredefinedUrlCategoriesResponseInner object itself.
      */
-    public PredefinedUrlCategoriesResponseInner withValue(List<PredefinedUrlCategory> value) {
+    public PredefinedUrlCategoriesResponseInner withValue(List<PredefinedUrlCategoryInner> value) {
         this.value = value;
         return this;
     }