fix(germany): Pentecost is not an official holiday - except in Brande…

…nburg (#337) * fix(Provider\Germany): pentecost is not an official holiday - except in Brandenburg (see #100)
azuyalabs · Dec 23, 2024 · 1c64419 · 1c64419
1 parent 8abe19f
commit 1c64419
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/Yasumi/Provider/Germany.php b/src/Yasumi/Provider/Germany.php
@@ -55,7 +55,7 @@ public function initialize(): void
         $this->addHoliday($this->easterMonday($this->year, $this->timezone, $this->locale));
         $this->addHoliday($this->goodFriday($this->year, $this->timezone, $this->locale));
         $this->addHoliday($this->internationalWorkersDay($this->year, $this->timezone, $this->locale));
-        $this->addHoliday($this->pentecost($this->year, $this->timezone, $this->locale));
+        $this->addHoliday($this->pentecost($this->year, $this->timezone, $this->locale, Holiday::TYPE_OTHER));
         $this->addHoliday($this->pentecostMonday($this->year, $this->timezone, $this->locale));
         $this->addHoliday($this->secondChristmasDay($this->year, $this->timezone, $this->locale));
 

diff --git a/tests/Germany/GermanyTest.php b/tests/Germany/GermanyTest.php
@@ -87,7 +87,10 @@ public function testBankHolidays(): void
      */
     public function testOtherHolidays(): void
     {
-        $this->assertDefinedHolidays([], self::REGION, $this->year, Holiday::TYPE_OTHER);
+        $this->assertDefinedHolidays([
+            'newYearsEve',
+            'pentecost',
+        ], self::REGION, $this->year, Holiday::TYPE_OTHER);
     }
 
     /**

diff --git a/tests/Germany/PentecostTest.php b/tests/Germany/PentecostTest.php
@@ -73,6 +73,6 @@ public function testTranslation(): void
      */
     public function testHolidayType(): void
     {
-        $this->assertHolidayType(self::REGION, self::HOLIDAY, $this->generateRandomYear(), Holiday::TYPE_OFFICIAL);
+        $this->assertHolidayType(self::REGION, self::HOLIDAY, $this->generateRandomYear(), Holiday::TYPE_OTHER);
     }
 }