Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repentance Day should be official in Germany/Saxony #63

Closed
scrobbleme opened this issue Aug 15, 2017 · 3 comments
Closed

Repentance Day should be official in Germany/Saxony #63

scrobbleme opened this issue Aug 15, 2017 · 3 comments
Assignees
Milestone

Comments

@scrobbleme
Copy link

scrobbleme commented Aug 15, 2017

Repentance Day is an official holidy in Germany/Saxony, but listet as "Others" within Yasumi

http://www.officeholidays.com/countries/germany/regional.php?list_year=2017&region_code=SN

@stelgenhof
Copy link
Member

Yes, the type "Others" is indeed not quite right for official regional holidays. The reason for choosing "Other" was probably because the other types didn't fit the classification.

Actually, the main classification "National" (within Yasumi) is then not appropriate in this regards. I think changing that name to "Official" might be a better wording. However that would require a change to all holiday providers. Which I think may be the correct way :)

For the moment, you can adjust it yourself by changing the type to "NATIONAL" if you like. Let me see if I can resolve this by changing "NATIONAL" to "OFFICIAL" or something like that.

@stelgenhof stelgenhof self-assigned this Aug 15, 2017
@stelgenhof stelgenhof added this to the v1.7.0 milestone Aug 15, 2017
@stelgenhof
Copy link
Member

Created branch 'official' where the name change from NATIONAL to OFFICIAL is done.

stelgenhof added a commit that referenced this issue Oct 13, 2017
@stelgenhof
Copy link
Member

Issue has been resolved in the master branch. Will be included in the upcoming v1.7.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants