Australian Public Holidays #112
Conversation
Proper handling for (just about) all public holidays in every Australian state and territory.
|
Thanks! Sorry for not replying sooner. There is no need to close PR's if something needed to change. |
| /** | ||
| * Returns a list of test dates | ||
| * | ||
| * @return array list of test dates for the holiday defined in this test | ||
| */ | ||
| public function HolidayDataProvider(): array | ||
| public function HolidayDataProvider() |
There was a problem hiding this comment.
Yasumi is supporting PHP7 going forward, so please use/keep any return type declarations.
There was a problem hiding this comment.
Sure, but this is probably going to be needed in a lot of the other ones I've written. I copied and pasted a lot. I'll go through and try to get them all.
src/Yasumi/Provider/Australia.php
Outdated
| * | ||
| * @throws \Yasumi\Exception\InvalidDateException | ||
| * @throws \InvalidArgumentException | ||
| * @throws \Yasumi\Exception\UnknownLocaleException | ||
| * @throws \Exception | ||
| */ | ||
| public function calculateHoliday( | ||
| string $shortName, | ||
| $shortName, |
There was a problem hiding this comment.
Yasumi is supporting PHP7 going forward, so please use/keep any return type declarations.
src/Yasumi/Provider/Australia.php
Outdated
| * @param bool $moveFromSunday | ||
| * @param string $shortName | ||
| * @param array $names | ||
| * @param string|DateTime $date |
There was a problem hiding this comment.
Please use the DateTime type only.
There was a problem hiding this comment.
Okay, that... breaks a lot. It will take me a few hours to make all the other changes to stop using strings everywhere.
Fixes requested for PHP7 compliance.
|
Okay, got those ones you pointed out, and all the other instances where they were copied. There could well be more missing type declarations, I was working based off the current release when adding the extra files, and I used copy+paste a lot. Just let me know if you see any and I'll deal with them. :) |
|
Thanks a lot! My apologies if I haven't been clear. Indeed the current stable release supports PHP 5.6 and greater. The development branch only supports PHP7 and greater and will be the basis for the next v2.0 release. I haven't documented/communicated that properly (yet). |
|
No problems. :) |
Proper handling for (just about) all public holidays in every Australian state and territory.