Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Japan's holiday for the 2020 Olympic Games. #113

Merged
merged 3 commits into from
Aug 11, 2018
Merged

Changing Japan's holiday for the 2020 Olympic Games. #113

merged 3 commits into from
Aug 11, 2018

Conversation

cookie-maker
Copy link
Contributor

It corresponds to the Japanese holiday of 2020.

In 2020
MarineDay: 2020/7/23
HealthAndSportsDay: 2020/7/24
MountainDay: 2020/8/10

http://www8.cao.go.jp/chosei/shukujitsu/gaiyou.html

@stelgenhof stelgenhof self-requested a review August 8, 2018 23:40
@stelgenhof stelgenhof added this to the v2.0.0 milestone Aug 8, 2018
Copy link
Member

@stelgenhof stelgenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can you update the CHANGELOG.md file describing these changes?

Also, please commit into the develop branch and not the master branch.

@cookie-maker cookie-maker changed the base branch from master to develop August 11, 2018 07:11
@cookie-maker
Copy link
Contributor Author

Thank you for confirmation.
Updated the ChangeLog and commit into the develop brach.

@stelgenhof stelgenhof merged commit 851d436 into azuyalabs:develop Aug 11, 2018
@cookie-maker cookie-maker deleted the jp2020 branch August 12, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants