Japanese Health And Sports Day rename to Sports Day since 2020. #129
Conversation
|
Thanks for this PR! Was about to do it myself but you were quicker :) よろしくお願いいたします！ |
|
@cookie-maker Just wanted to check if you were able to review my comments. |
|
sorry I'm late. |
|
You can find my comments here on Github in this PR. |
|
I am sorry I do not know how to use Github. |
|
No problem. My apologies, as I don't always realize not everybody uses Github often. On this page you can scroll down the page to see the changes and also comments and feedback from others. See this screenshot:
You can there respond or provide other comments. Hopefully that clarifies it. Cheers! Sacha |
|
Thank you for your kindness. This is the screen that I see.
Maybe, the submit review button is not pressed. |
tests/Japan/SportsDayTest.php
Outdated
| * 2020 - :Sports Day | ||
| * @throws \ReflectionException | ||
| */ | ||
| public function testTranslation2(): void |
There was a problem hiding this comment.
I think it would be better to give a more descriptive name rather than '2' :). Perhaps this is better:
| public function testTranslation2(): void | |
| public function testTranslationFrom2020(): void |
src/Yasumi/Provider/Japan.php
Outdated
| @@ -443,10 +443,15 @@ private function calculateHealthAndSportsDay(): void | |||
| $date = new DateTime("$this->year-10-10", new DateTimeZone($this->timezone)); | |||
| } | |||
|
|
|||
| $holyday_name =['en_US' => 'Health And Sports Day', 'ja_JP' => '体育の日']; | |||
There was a problem hiding this comment.
Minor note: $holyday_name should be $holiday_name :) Just a small grammar mistake.
|
@cookie-maker Thanks for the screenshot. Nothings is wrong. You are absolutely right, I forgot to press Submit. I feel so stupid, haha. I did it now, so hopefully you can see it. Cheers! Sacha |
|
ありがとうございます！ I found your comment! よろしくおねがいいたします！ |
|
いつもありがとうございます！すぐにあなたの他のPRを検証します。 |
Japanese [Health And Sports Day(体育の日)] rename to [Sports Day(スポーツの日)] since 2020.
https://www8.cao.go.jp/chosei/shukujitsu/gaiyou.html