Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AFL Grand Final Friday dates for 2019 / 2020 #190

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Add AFL Grand Final Friday dates for 2019 / 2020 #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1f52f5
Add AFL Grand Final Friday dates for 2019 / 2020
brucealdridge Dec 15, 2019
989cf51
Update CHANGELOG.md
brucealdridge Dec 16, 2019
ed953ea
Update AFLGrandFinalFridayTest.php
brucealdridge Dec 16, 2019
59f8044
Updating copy/pasted year
brucealdridge Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/) and this
## [Unreleased]

### Added

- Additional Dates for Australia/Victoria:AFL Grand Final Friday [\#190](https://github.com/azuyalabs/yasumi/pull/190) ([brucealdridge](https://github.com/brucealdridge))
### Changed

### Fixed
Expand Down
6 changes: 6 additions & 0 deletions src/Yasumi/Provider/Australia/Victoria.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,12 @@ private function calculateAFLGrandFinalDay(): void
case 2018:
$aflGrandFinalFriday = '2018-09-28';
break;
case 2019:
$aflGrandFinalFriday = '2019-09-27';
break;
case 2020:
$aflGrandFinalFriday = '2020-09-25';
break;
default:
return;
}
Expand Down
4 changes: 3 additions & 1 deletion tests/Australia/Victoria/AFLGrandFinalFridayTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class AFLGrandFinalFridayTest extends VictoriaBaseTestCase implements YasumiTest
public const HOLIDAY = 'aflGrandFinalFriday';

public const ESTABLISHMENT_YEAR = 2015;
public const LAST_KNOWN_YEAR = 2018;
public const LAST_KNOWN_YEAR = 2020;

/**
* Tests AFL Grand Final Friday
Expand Down Expand Up @@ -103,6 +103,8 @@ public function HolidayDataProvider(): array
[2016, '2016-09-30'],
[2017, '2017-09-29'],
[2018, '2018-09-28'],
[2019, '2019-09-27'],
[2020, '2020-09-25'],
];

return $data;
Expand Down