-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SouthKorea provider to apply the new substitute holidays changed in June 2021. #255
Conversation
Super! Thanks so much. |
We should postpone merging this pr until complete the selection of substitute holiday. |
…dential Decree, which took effect on August 4.
… President Degree.
http://www.koreaherald.com/view.php?ud=20210803000365 |
@stelgenhof Static snalysis is always failed for Yasumi/Yasumi.php. Even fork upstream to another repository and run actions, it was failed. |
@barami I am aware of the CI failing. Some issue in the core files causing this. I will have a look. |
@barami I've fixed the issues with the CI. Please update your branch. Thanks! |
The |
@barami Can you also update the CHANGELOG.md file (on the top) that explains the this PR (in non-technical terms as much as possible). Thanks! |
@stelgenhof Also, I will update CHANGELOG.md as you say. |
Hi.
The new substitute holidays bill was passed in korea on june 2021.
I have updated SouthKorea provider and added tests for substitute holidays.
https://en.yna.co.kr/view/AEN20210629007500315
http://tbs.seoul.kr/eFm/newsView.do?typ_800=N&idx_800=3441140&seq_800=