Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ext-intl to required extensions #306

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Adds ext-intl to required extensions #306

merged 2 commits into from
Jan 9, 2023

Conversation

freshleafmedia
Copy link
Contributor

The ext-intl extension is required to run tests since 111c2e6. Specifically due the to usage of intltz_get_tz_data_version

@stelgenhof
Copy link
Member

Thank you @freshleafmedia for this PR. I am aware of this and had not yet added the extension as a requirement since the CI pipeline is failing for the Windows OS. I recall trying to add the extension in the GitHub actions but didn't seem to solve the issue. I left it since, but should look into it again.

@freshleafmedia
Copy link
Contributor Author

That's odd. The tests were passing before so that must mean that the extension is present. Otherwise an exception would have been thrown 🤔

It's as though Composer doesn't detect it but it is there at runtime? Is it using a different php.ini maybe? Doesn't make any sense to me

@stelgenhof
Copy link
Member

What OS are you using locally then? As you can see here in the actions log https://github.com/azuyalabs/yasumi/actions/runs/3854998767/jobs/6569582950#step:8:19 the extension seems to be missing.

@stelgenhof stelgenhof merged commit 9ca3bb6 into azuyalabs:develop Jan 9, 2023
@freshleafmedia freshleafmedia deleted the intl-ext-required branch January 9, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants