Added Portugal holiday provider #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some additional translations related to the provider
|
Thanks for this PR! Let me have a look and merge it if all is fine :) |
stelgenhof
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Sacha and maintainers,
I have created a provider for holidays in Portugal. The 2016 calendar in Portugal has 13 national holidays and I included only those 13. I plan on including some regional holidays as well in the future as well as past holidays that no longer exist (e.g. the 10th of June holiday had a different name between 1933 and 1973).
A few of the holidays present in 2016 were abolished in 2014 and restored this year (2016) and that factor is taken into account in the provider.
These three holidays are:
I await your feedback.
Thank you and best regards,
Ricardo Velhote