Provider for holidays in Latvia #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukosius
commented
Oct 16, 2017
•
lukosius
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
lukosius
changed the title
|
Thank you @lukosius for the PR! I'll have a look once you have added the unit tests. Without unit tests it would make it harder for me to verify and it ensures the quality of the library. |
# Conflicts: # src/Yasumi/data/translations/christmasDay.php # src/Yasumi/data/translations/christmasEve.php # src/Yasumi/data/translations/easter.php # src/Yasumi/data/translations/easterMonday.php # src/Yasumi/data/translations/internationalWorkersDay.php # src/Yasumi/data/translations/newYearsDay.php # src/Yasumi/data/translations/secondChristmasDay.php
lukosius
changed the title
|
Added tests for the provider and some useful helpers. |
stelgenhof
reviewed
Oct 22, 2017
tests/YasumiBase.php
Outdated
| */ | ||
| public function isWeekend(\DateTimeInterface $dateTime) | ||
| { | ||
| return in_array((int) $dateTime->format('w'), [0, 6], true); |
There was a problem hiding this comment.
Although in many countries weekend is considered to be Saturday and Sunday, in other countries it isn't. Need to be aware of that when using this function.
stelgenhof
approved these changes
Oct 23, 2017
stelgenhof
approved these changes
Nov 13, 2017
stelgenhof
added a commit
that referenced
this pull request
Dec 19, 2017
* Added Countable interface allowing proper of number of holidays is returned when using the count() function or ->count() method. * Fixed styling. * Adjusted unit test for Portugal so that the holiday of Corpus Christi is not validated between 2013 and 2016. Corpus Christi was not officially celebrated between 2013 and 2016. * Provider for holidays in Latvia (#70) * Add provider for official Latvia holidays * Add translations for official Latvia holidays * Add additional tests helpers * Add tests for official Latvia holidays * Update other tests using generateRandomDatesWithModifier * Add default parameter to isWeekend to allow overwrite default weekend days * Update CHANGELOG.md * Implemented the Countable interface for all filters. Signed-off-by: Sacha Telgenhof <[email protected]> * Removed 'statehoodDay' from initial array as it is established at a particular year. Signed-off-by: Sacha Telgenhof <[email protected]> * Code cleanup. Signed-off-by: Sacha Telgenhof <[email protected]> * Sorted translations. Signed-off-by: Sacha Telgenhof <[email protected]> * Fixed test cases for Geneva as the holidays 'jeuneGenevois' and 'restaurationGenevoise' are established/restored at different moments in time. Signed-off-by: Sacha Telgenhof <[email protected]> * Updated for 1.7.0 release. Signed-off-by: Sacha Telgenhof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.