Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider for holidays in Russia #72

Merged
merged 4 commits into from
Jan 6, 2018
Merged

Provider for holidays in Russia #72

merged 4 commits into from
Jan 6, 2018

Conversation

lukosius
Copy link
Contributor

@lukosius lukosius commented Oct 17, 2017

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes

Not sure about New Year's holiday week.

@stelgenhof
Copy link
Member

Thank you @lukosius for the PR! I'll have a look once you have added the unit tests. Without unit tests it would make it harder for me to verify and it ensures the quality of the library.

@lukosius lukosius changed the title [WIP] Provider for holidays in Russia Provider for holidays in Russia Dec 20, 2017
@stelgenhof stelgenhof self-requested a review December 24, 2017 01:35
@stelgenhof stelgenhof self-assigned this Dec 24, 2017
@stelgenhof stelgenhof merged commit 7d789c5 into azuyalabs:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants