Holiday Provider for Bosnia #94
Conversation
|
Thanks for the PR! According to my research, these are not all the official Bosnian holidays, are they? For example, I saw there is a second New Years Day and a second Labour Day. Do you maybe have a good resource that explains the official/national holidays? Cheers! Sacha |
|
Hey Sacha, thanks for the info, I thought it was by default that the second New Years Day and Labour day were holidays, my bad. Cheers, Adnan 🌷 |
src/Yasumi/Provider/Bosnia.php
Outdated
| use Yasumi\Holiday; | ||
|
|
||
| /** | ||
| * Provider for all holidays in Croatia. |
There was a problem hiding this comment.
You might want to correct this :) Please also check everywhere else in all the files if there is anything that needs to be changed.
src/Yasumi/Provider/Bosnia.php
Outdated
| /** | ||
| * Provider for all holidays in Croatia. | ||
| * | ||
| * @author Karlo Mikus <[email protected]> |
There was a problem hiding this comment.
You can change it to your name :)
src/Yasumi/Provider/Bosnia.php
Outdated
| * Code to identify this Holiday Provider. Typically this is the ISO3166 code corresponding to the respective | ||
| * country or sub-region. | ||
| */ | ||
| const ID = 'BS'; |
There was a problem hiding this comment.
According to https://en.wikipedia.org/wiki/ISO_3166-2:BA, the ISO3166-2 code for Bosnia and Herzegovina is 'BA'.
|
I think it looks good now. However, due to the various religions and various jurisdictions in Bosnia, maybe other holidays need to be added. Source: https://en.wikipedia.org/wiki/Public_holidays_in_Bosnia_and_Herzegovina |
|
There are at least two holidays from the islamic calendar (hence the issue/suggestion earlier), and I think some Orthodox Christian holidays (gotta research this a bit more), so I'll update this again soon :) |
|
No problem. I merged already the code into the 'develop' branch. If you have any PR's, please submit for the 'develop' branch. The master branch is considered production level code :) |
|
Oh sorry, I'll keep that in mind next time 😃 |
No description provided.