New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider faster method of deleting all children of a given node #9

Closed

pkozlowski-opensource opened this issue Jul 27, 2017 · 1 comment

Collaborator

pkozlowski-opensource commented Jul 27, 2017

Iv wasn't doing great (that is, wasn't the best :-)) in the delete many rows benchmark and here are some hints about what other frameworks are doing: https://github.com/krausest/js-framework-benchmark/blob/85a6d94f31c79c75eb2d4d9bc7ce997e3dfde938/vanillajs-non-keyed/src/Main.js#L262-L284

Hint: parentNode.textContent = "" should be the fastest according to this benchmark and DOM spec: whatwg/dom#478 (comment)

The text was updated successfully, but these errors were encountered:

b-laporte pushed a commit that referenced this issue


          fix: issue #9 - faster method to delete child nodes

cc09129

Owner

b-laporte commented Aug 16, 2017 •

edited

Loading

Thx for the tip - I just pushed the fix on master :-)

b-laporte closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment