Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get_indices_for_active_step by caching the result according t… #265

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

Dref360
Copy link
Member

@Dref360 Dref360 commented Jun 23, 2023

…o the current AL step

Summary:

A faster way would be to clear the cache only when we call label, but that would break the encapsulation IMO. So leaving it at that, it is still 10x better.

Features:

Checklist:

  • Your code is documented (To validate this, add your module to tests/documentation_test.py).
  • Your code is tested with unit tests.
  • You moved your Issue to the PR state.

@Dref360 Dref360 requested a review from parmidaatg June 26, 2023 13:29
@Dref360 Dref360 merged commit fa16d5d into master Jul 13, 2023
@Dref360 Dref360 deleted the fix/al_dataset_speed branch July 13, 2023 21:22
@Dref360 Dref360 restored the fix/al_dataset_speed branch July 13, 2023 21:34
Dref360 added a commit that referenced this pull request Jul 13, 2023
* Add caching mechanism for MCDropout

* Run poetry.lock

* Add tests

* Optimize caching

* Add documentation

* Improve get_indices_for_active_step by caching the result according t… (#265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant