Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Debugging and Installation Process #57

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

babarot
Copy link
Owner

@babarot babarot commented Feb 10, 2025

WHAT

  1. Improved --debug flag behavior

    • Introduced two modes:
      • full: Displays the entire log history before following new log entries in real-time.
      • live: Starts from the latest log entry and follows new logs in real-time.
    • Adjusted CLI implementation to support this change.
  2. Refactored installation script (hack/install)

    • Improved handling of binary downloads with clearer error messages.
    • Introduced a structured installation method (binary vs. source build).
    • Replaced go install with git clone + make install for a more reliable build process.
  3. Refactored CLI options

    • Grouped --version and --debug under MetaOption for better organization.
  4. Other improvements

    • Updated the official gomi URL to https://gomi.dev.
    • Improved log handling logic for better debugging experience.

WHY

  • To provide more precise debugging options.
  • To enhance error handling and improve user experience in installation.
  • To improve code maintainability and clarity.

@babarot babarot added kind/feature A feature request; new or enhanced behavior kind/cleanup Categorizes issue or PR as related to cleaning up code, issues, etc. release/minor Indicates minor version to bump up next when creating release PR. labels Feb 10, 2025
@babarot babarot merged commit 1699c65 into main Feb 10, 2025
5 checks passed
@babarot babarot deleted the babarot/debug branch February 10, 2025 10:56
@github-actions github-actions bot mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, issues, etc. kind/feature A feature request; new or enhanced behavior release/minor Indicates minor version to bump up next when creating release PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant