-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIDER hanging with newer babashka.nrepl #45
Comments
@giuliano108 It would be useful if you can detect the most recent bb that still worked before 0.6.1: |
It's still working for me with CIDER but I haven't upgraded CIDER for a while. Could you also specify your CIDER version? |
For the record, I'm using cider 1.2.0-snapshot (from July). |
Now upgraded to the newest 1.2.0-snapshot released on 14th of September, still works. Do you have some code you are running for reproduction? |
I tried both I'm saying "was" because as I was trying every bb release in turn, I stopped being able to reproduce the issue... 😞 The same operation that was getting no response before ( I'm sorry for wasting your time, I'll close the issue and will come back with better data if I come across it again in the future. Thanks for babashka!
|
@borkdude, I've managed to reproduce the issue outside of CIDER, by using the "official" This is the repro script: (require '[clojure.pprint :refer [pprint]])
(require '[nrepl.core :as nrepl])
(with-open [conn (nrepl/connect :port 1667)]
(let [client (nrepl/client conn 1000)]
(println "### 1 - Sending")
(time
(-> client
;; setting a :ns other than "user" triggers a different behaviour
;; depending on the version of babashka
;; bb 0.5.0 -> all OK
;; bb 0.5.1 and newer -> both nrepl/message calls time out
(nrepl/message {:op "eldoc" :sym "->>" :ns "somens"})
doall
pprint))
(println "### 1 - Received\n")
(println "### 2 - Sending")
(time
(-> client
(nrepl/message {:op "eval" :code "(+ 1 1)" :ns "user"})
doall
pprint))
(println "### 2 - Received\n")))
(System/exit 0) I run it with:
Newer babashkas, including
|
Thank you! |
I can reproduce this with executing your script against v0.5.0 vs v0.6.0:
|
Found the issue. What OS are you using with bb? I can provide a binary for testing later today. |
Here is a linux binary: https://22909-201467090-gh.circle-artifacts.com/0/release/babashka-0.6.2-SNAPSHOT-linux-amd64.tar.gz In case you need a different OS, let me know. |
I'm having issues getting CIDER to talk to babashka 0.6.1 nREPL . CIDER hangs afer evaluating the first form. When using babashka 0.4.1 everything works fine. I tried multiple versions of CIDER / babashka.
In
Emacs
, I've setnrepl-log-messages
tot
, causing CIDER to log all the nREPL messages sent/received.With bb 0.4.1 , I see CIDER sending 2
eldoc
ops (id=6 and id=7), folloed by aneval
(id=8). bb immediately repliesno-eldoc
to id=6 and id=7 . id=8, as expected gets the result of theeval
.With bb 0.6.1 , bb doesn't reply to the 2
eldoc
ops or theeval
. Ops 6, 7 and 8 go unanswered. I double checked withtcpdump
to confirm that the responses are missing from the "wire" as well.You should be able to see the full side-by-side logs here:
https://gist.github.com/giuliano108/47edecde5f64d964a596ffda1d2ba907/revisions?diff=split#diff-eda0f6fe7e39e7b95b3db19a55a8f05c2f3e3c84d72039dc945aa9a17fb582cbL92
The text was updated successfully, but these errors were encountered: