exec does not convert :env and :extra-env keywords

[lread]

Problem

While working on #117 I have found that exec does not convert :env and :extra-env like process does.

Repro

This applies to all platforms, but I'll show behaviour on Linux.
It is easiest for me to demonstrate running from bb as exec only works when natively compiled:

❯ bb --version
babashka v1.3.179

Given file repro.clj

(require '[babashka.process :as p]
         '[clojure.edn :as edn])

(def opts (-> *command-line-args*
              first
              edn/read-string))

;; -cp '' so that bb does not require JAVA_HOME
(def cmd "bb -cp '' script/wd.clj :env")

(println "Testing with opts:" (pr-str opts))

(println "Running p/process")
(-> (p/process opts cmd)
    :out
    slurp
    println)

(println "Running p/exec")
(p/exec opts cmd)

:env

All strings - all good

If we use string keys and vals, all good:

> bb repro.clj '{:env {"k1" "v1" "k2" "v2" "k3" "v3"}}' 
Testing with opts: {:env {"k1" "v1", "k2" "v2", "k3" "v3"}}
Running p/process
{"k3" "v3", "k1" "v1", "k2" "v2"}
Running p/exec
{"k3" "v3", "k1" "v1", "k2" "v2"}%    

Keyword for key - exec fails

But if we use keyword for key, process works, but exec fails:

❯ bb repro.clj '{:env {"k1" "v1" :k2 "v2" "k3" "v3"}}' 
Testing with opts: {:env {"k1" "v1", :k2 "v2", "k3" "v3"}}
Running p/process
{"k3" "v3", "k1" "v1", "k2" "v2"}
Running p/exec
----- Error --------------------------------------------------------------------
Type:     java.lang.ClassCastException
Message:  clojure.lang.Keyword cannot be cast to java.lang.String
Location: /home/lee/proj/oss/babashka/process/repro.clj:20:1

----- Context ------------------------------------------------------------------
16:     slurp
17:     println)
18: 
19: (println "Running p/exec")
20: (p/exec opts cmd)
    ^--- clojure.lang.Keyword cannot be cast to java.lang.String

----- Stack trace --------------------------------------------------------------
babashka.process/exec - <built-in>
user                  - /home/lee/proj/oss/babashka/process/repro.clj:20:1

Keyword for val - exec fails

Same idea if we use keyword for val:

❯ bb repro.clj '{:env {"k1" "v1" "k2" :v2 "k3" "v3"}}' 
Testing with opts: {:env {"k1" "v1", "k2" :v2, "k3" "v3"}}
Running p/process
{"k3" "v3", "k1" "v1", "k2" ":v2"}
Running p/exec
----- Error --------------------------------------------------------------------
Type:     java.lang.ClassCastException
Message:  clojure.lang.Keyword cannot be cast to java.lang.String
Location: /home/lee/proj/oss/babashka/process/repro.clj:20:1

----- Context ------------------------------------------------------------------
16:     slurp
17:     println)
18: 
19: (println "Running p/exec")
20: (p/exec opts cmd)
    ^--- clojure.lang.Keyword cannot be cast to java.lang.String

----- Stack trace --------------------------------------------------------------
babashka.process/exec - <built-in>
user                  - /home/lee/proj/oss/babashka/process/repro.clj:20:1

:extra-env

Repros not shown but same idea for:

> bb repro.clj '{:extra-env {"k1" "v1" "k2" :v2 "k3" "v3"}}' 
> bb repro.clj '{:extra-env {"k1" "v1" :k2 "v2" "k3" "v3"}}'
> bb repro.clj '{:extra-env {"k1" "v1" "k2" :v2 "k3" "v3"}}'  

Expected Behaviour

exec should convert keywords to strings for :env and :env-var like process does.

Next Steps

An easy fix, I handle this with #117

[borkdude]

Sounds good.