Initial Docusaurus rewrite #1521
Conversation
|
Deploy preview for babel ready! Built with commit 587b885 |
|
That is looking nice! Should we keep our old design or change it by the way? |
|
I don't think we should go out of our way to keep it so maybe both 😛 - vuejs.org, https://reactjs.org/, https://deploy-preview-3718--prettier.netlify.com/ look pretty nice @azz if you have ideas I guess we just need to get the content (docs) back in working order and just continue to iterate otherwise it will take forever for this to happen and we need it asap for the content not to make it look nice. |
|
@hzoo Hi! Thanks for giving Docusaurus a go. Let us know if you have any questions as you work through the conversion. You can jump into our Discord channel, file an issue on the Docusaurus repo, or just comment here. cc: @ericnakagawa |
| - name: npm | ||
| url: https://www.npmjs.com | ||
| logo: npm.svg | ||
| pinned: true |
There was a problem hiding this comment.
Is this change related? If not, could you submit it as a separate PR?
|
Sorry it I didn't mean to ask to review the code perse since at the top I said it would be impossible to do in a PR. It was more about feedback on the UI and the other things - or if there is something not covered in my bullet points that you are aware of. Or maybe related to deployment/versioning/redirects |
|
oh, lol, I'm not sure how I missed that. This page doesn't work properly (has some markup showing): https://deploy-preview-1521--babel.netlify.com/docs/en/setup.html One thing we should ensure is kept is URLs. For example, https://deploy-preview-1521--babel.netlify.com/docs/usage/caveats/ throws a 404 because the URL has changed to https://deploy-preview-1521--babel.netlify.com/docs/en/caveats.html. If it's impossible to keep exactly the same URLs, then the old URLs should 301 (permanent) redirect to new ones. You can do this with Netlify by using a |
|
@Daniel15 yeah i'm tracking the pages that don't work in the ^ but I didn't do a good job of explaining haha (setup is one of them) yeah exactly we want to keep old urls and redirect 👍 👍 |
|
Ok made a new site on netlify so we can make a new branch to target for the old site: |
|
Hey guys, are there any tasks I can take over? I would love to participate. |
|
Same here! I'd love to tackle some thing/s this weekend :D |
* feat(videos): convert the videos page into react component * update: change video.css * update: rm old videos file * fix: add @media screen into video.css
|
Yeah @GregBorrelly, @SavePointSam, and anyone else looking - I already made a few issues tagged in this PR that people can do as separate tasks. It's mostly making sure that we can bring back functionality from the current site (babeljs.io) into this one (check the preview url), so anything you can do for that would be appreciated since it all adds up. Sometimes it's worth rewriting too if you feel inspired too. |
* added styles for user * added browser hack for transform
* Add repl to new site * Tweak styles * Remove old things * height: 100% fallback
* team page added.(#1523) * custom page team added to header links * unique key prop warning fixed.unwanted variable removed * code refactoring, composed jsx elements into functional comps * responsive design bug fixed * container left,right padding removed for more usage of space * common styles from video.css & team.css -> babel.css
* removed maincontainer from css style where it could be removed for users page * updated styles?
|
Will make a new issue #1485 (comment) |
preview: https://deploy-preview-1521--babel.netlify.com/
Shouldn't look at the diff since there's too many files changed, looking for more PRs against it
priority/easy
<!--truncate-->commentsold-site, url is https://old.babeljs.io/){% include package_readme.html %}[@existentialism is working on this right now]<head>: should we keep things from https://github.com/babel/website/blob/master/_includes/head.html?special pages