improve delegation return type #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/v2/service/staker.go
Outdated
| UnbondingTx string `json:"unbonding_tx"` | ||
| FinalityProviderBtcPksHex []string `json:"finality_provider_btc_pks_hex"` | ||
| DelegationStaking DelegationStaking `json:"delegation_staking"` | ||
| DelegationUnbonding DelegationUnbonding `json:"delegation_unbonding"` | ||
| State indexertypes.DelegationState `json:"state"` | ||
| StartHeight uint32 `json:"start_height"` |
There was a problem hiding this comment.
the start time is the staking start time right? should it be part of the DelegationStaking?
could u also remind me what is endTime?
also i think this two are optional, so u might wanna put json omit
There was a problem hiding this comment.
we only have end_height, do you mean unbonding_time?
jrwbabylonlab
approved these changes
Nov 13, 2024
|
the FE is now using the v2 endpoint. please make sure raise PR against simple-staking to avoid the broken UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#104
will update the return type here and
simple stakingafter merging