Pass $ alongside TVL #489

[kirugan]

Issue babylonlabs-io/simple-staking#489

[jeremy-babylonlabs]

Very nice job, can you update the swagger as well?

[gusin13]

i couldn't find issue 489 ticket, can you please refer me to the ticket or provide more context on the pr?

[jeremy-babylonlabs]

This PR is related to the ticket @gusin13 did before on phase-1, which adds btcusd in the reaponse

[gusin13]

@jeremy-babylonlabs @jrwbabylonlab sorry i am bit confused, is this change to support /v1/stats but aren't we deprecating it?

even in that case shouldn't we simply cherry-pick the merge commit from this pr (in 0.3.x branch) and merge in main?

[jrwbabylonlab]

@jeremy-babylonlabs @jrwbabylonlab sorry i am bit confused, is this change to support /v1/stats but aren't we deprecating it?

even in that case shouldn't we simply cherry-pick the merge commit from this pr (in 0.3.x branch) and merge in main?

I think i left a comment somewhere in the PR, but couldn't find it anymore.
We no longer need it for phase-1. But does not harm to continue support it in the phase-1 endpoint.
The more important part of the PR here is ensure the price is reflected in one of the endpoint so that our FE can display it.
Maybe we made a wrong decision for phase-1 where we directly performed the $ calculation for tvl. What we could do is provide the conversion rate in a generic network information endpoint so that FE can do its own calculation which is more flexible.
@kirugan what u think?

[jrwbabylonlab]

Apart from the above comments need to be addressed, recommend adding below two as well:

1. Let's start adding tests. A simple set of API request & response test cover happy&unhappy path
2. Ensure the endpoint is only available/accept requests if the config is set for the pricing

[gusin13]

Some suggestions -

1. We can do the same changes we did in /v1/stats endpoint and copy them to /v2/stats, I think this is what @kirugan did when pr was opened for review. We can merge this change first to main.
2. After this we can open separate tickets/prs if needed to make further improvements as needed.

[kirugan]

need to setup during deployment