Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add models for API key operations #2

Merged
merged 6 commits into from
Oct 28, 2022
Merged

Add models for API key operations #2

merged 6 commits into from
Oct 28, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Oct 27, 2022 •
edited
Loading

Describe what the PR does:

This PR adds data models for API key-related operations:

  • GetKeysResponse
  • InvalidApiKeyResponse

It also cleans up some pre-commit items needed to make CI work.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Oct 27, 2022
@bachya bachya self-assigned this Oct 27, 2022
@bachya bachya changed the title Add a model for a response to GET /keys Add models for API key operations Oct 27, 2022
@codeclimate
Copy link

codeclimate bot commented Oct 28, 2022

Code Climate has analyzed commit 36f06a0 and detected 0 issues on this pull request.

View more on Code Climate.

@bachya bachya merged commit cf4c09b into dev Oct 28, 2022
@bachya bachya deleted the model-keys branch October 28, 2022 00:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bachya bachya

Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bachya