Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] What needs to be done to move this module to core #117

Closed
indigoxela opened this issue Dec 12, 2023 · 7 comments
Closed

[META] What needs to be done to move this module to core #117

indigoxela opened this issue Dec 12, 2023 · 7 comments
Labels
type - question Further information is requested

Comments

@indigoxela
Copy link
Member

What's the status of this module and at which point is it ready to get moved to core?

It seems like almost (#76) all the potentially blocking issues known from Drupal have been addressed (#36).
Or did new ones pop up?

The module still has bugs, but on the other hand, it might get more attention and testing, if it's integrated in core.

  • Which issues do we want to be closed before moving?
  • Which issues are OK to pull over to the core queue?
  • Are there issues, that are OK to postpone?
@quicksketch quicksketch added the type - question Further information is requested label Dec 12, 2023
@quicksketch
Copy link
Member

Which issues do we want to be closed before moving?

Are there issues, that are OK to postpone?

Which issues are OK to pull over to the core queue?

Everything else should be pulled over to the core queue I think.


Other things: we should make a release that expresses a bit more confidence in its version number, i.e. 1.0.0.

I started a blog post to describe the whole upgrade/transition process but I haven't finished it yet.

@quicksketch
Copy link
Member

Blog post draft (unpublished): https://backdropcms.org/news/backdrop-cms-upgrade-from-ckeditor-4-to-5

@olafgrabienski
Copy link
Member

Great to have an upcoming Blog post! Are there plans to publish it soon? Just read the post, looks great. Only suggestion: Make more clear in some text passages if they refer to the upcoming core version or to the contrib version of CKE 5. Also add a link to the contrib version.

@quicksketch
Copy link
Member

Ah, sorry I meant to add links. I'll revise that tomorrow. Thanks @olafgrabienski! And I'll clarify as you suggest.

@quicksketch
Copy link
Member

I added screenshots and published the blog post! https://backdropcms.org/news/upgrade-from-ckeditor-4-to-5

@quicksketch
Copy link
Member

I considered making another alpha/beta/RC release, but after experiences of contrib modules that never reach a final version, I decided to make the jump to publish a stable version number. So I made it the 1.x-1.0.0 version, which is now released. https://github.com/backdrop-contrib/ckeditor5/releases/tag/1.x-1.0.0

Note we will still likely have additional releases 1.0.1, 1.0.2, etc.

@quicksketch
Copy link
Member

Per backdrop/backdrop-issues#4122, this module is now included in core! We did it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type - question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants