Config key cketoolbar vs toolbar?

[quicksketch]

At some point the config key and form element for the toolbar was changed from toolbar to cketoolbar. This is unnecessary prefixing, since the settings are exclusive to the ckeditor5 editor. It'll probably show up in core's cSpell as an invalid word too. Should we change it back?

[indigoxela]

This is unnecessary prefixing, since the settings are exclusive to the ckeditor5 editor.

In fact, this change was essential to get things working. Reverting isn't possible without changes in core.

See also backdrop/backdrop-issues#6203

This filter quirk not only affects CK5, but any other editor with such a setting in the filter form. If an implementation uses "toolbar", then things will break because of different variable structure for the editors.

[indigoxela]

A little off topic: I don't think, cspell should dictate the names of variables. Nice and speaking names, OK, but not being able to use (proper) variables names because of a spellchecker... 🤪

[quicksketch]

I'd like to put this config key back to just "toolbar", but you're right that we can't do this easily while there's the core bug. I filed a PR at #114 but it's blocked until backdrop/backdrop-issues#6203 is fixed and we have another bug-fix release (1.26.3).

[quicksketch]

I merged the PR at #114, but @indigoxela pointed out some pretty serious flaws in the update hook as part of the core code review. I should have retested this again before merging. I filed a follow-up PR at #123 that fixes our new test coverage and corrects the update hook to save the new config values.

[quicksketch]

Also #123 fixed our test runs by checking out Backdrop 1.26.x instead of 1.x, because this contrib module conflicts with the new core module.