Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate announcements react from procore-oss #2404

Merged
merged 9 commits into from
Dec 26, 2024
Merged

Migrate announcements react from procore-oss #2404

merged 9 commits into from
Dec 26, 2024

Conversation

kurtaking
Copy link
Member

@kurtaking kurtaking commented Dec 25, 2024 •
edited
Loading

Hey, I just made a Pull Request!

  • migrate announcements-react
  • update announcements (frontend) plugin to use @backstage-community/plugin-announcements-react
  • replace remaining @procore-oss imports with @backstage-community equivalent

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@kurtaking kurtaking changed the title Migrate announcements react Migrate announcements react from procore-oss Dec 25, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 25, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-announcements-backend workspaces/announcements/plugins/announcements-backend none v0.1.0
@backstage-community/plugin-announcements-common workspaces/announcements/plugins/announcements-common none v0.1.0
@backstage-community/plugin-announcements-node workspaces/announcements/plugins/announcements-node none v0.1.0
@backstage-community/plugin-announcements-react workspaces/announcements/plugins/announcements-react none v0.1.0
@backstage-community/plugin-announcements workspaces/announcements/plugins/announcements none v0.1.0
@backstage-community/plugin-search-backend-module-announcements workspaces/announcements/plugins/search-backend-module-announcements none v0.1.0

@kurtaking kurtaking mentioned this pull request Dec 25, 2024
Closed
6 tasks
@kurtaking
fix api report
83b8c1c 
Signed-off-by: Kurt King <[email protected]>
@kurtaking kurtaking marked this pull request as ready for review December 25, 2024 21:46
@kurtaking kurtaking requested a review from a team as a code owner December 25, 2024 21:46
@kurtaking kurtaking requested a review from nickboldt December 25, 2024 21:46
awanlin
awanlin approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @kurtaking 🎄

@awanlin awanlin merged commit aa6786a into backstage:main Dec 26, 2024
12 checks passed
@kurtaking kurtaking deleted the migrate-announcements-react branch December 26, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awanlin awanlin awanlin approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner automatically assigned from backstage/community-plugins-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtaking @awanlin