Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restic restore nonexist path, ignore lost+found on backup empty dir check #1190

Merged

Conversation

tesshuflower
Copy link
Contributor

Describe what this PR does

  • Allows a restic restore to a non-existent path - will initialize the path if it doesn't exist (as is done in a backup). This still means backups will fail if bad credentials are supplied
  • Ignore lost+found on restic backup when checking for empty source volume

Want to fix in main and then cherry-pick into release-0.9 (to be included in v0.9.1).

Is there anything that requires special attention?

Related issues:

#1172
#1181

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tesshuflower
Copy link
Contributor Author

/cc @JohnStrunk

@openshift-ci openshift-ci bot requested a review from JohnStrunk March 26, 2024 18:27
Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.4%. Comparing base (f50f090) to head (a5319d9).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1190     +/-   ##
=======================================
+ Coverage   67.3%   67.4%   +0.1%     
=======================================
  Files         57      57             
  Lines       5803    5803             
=======================================
+ Hits        3910    3916      +6     
+ Misses      1605    1602      -3     
+ Partials     288     285      -3     
Files Coverage Δ
controllers/mover/restic/logfilter.go 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

@openshift-merge-bot openshift-merge-bot bot merged commit 24b98f6 into backube:main Mar 26, 2024
29 checks passed
@tesshuflower
Copy link
Contributor Author

/cherry-pick release-0.9

@tesshuflower tesshuflower deleted the restic_restore_nonexist_path branch March 26, 2024 19:01
@openshift-cherrypick-robot

@tesshuflower: new pull request created: #1191

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants