Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dest snapshot wait for readyToUse=true #1520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dest snapshot wait for readyToUse=true #1520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f35de
dest snapshot wait for readyToUse=true
tesshuflower Jan 14, 2025
1c28f25
debug logging
tesshuflower Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions controllers/volumehandler/volumehandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,15 @@
}
return nil, nil
}
logger.V(1).Info("snapshot content is bound")
if snap.Status.ReadyToUse != nil && !*snap.Status.ReadyToUse {
// readyToUse is set to false for this volume snapshot
logger.V(1).Info("waiting for snapshot to be ready")
return nil, nil
}

Check warning on line 309 in controllers/volumehandler/volumehandler.go

View check run for this annotation

Codecov / codecov/patch

controllers/volumehandler/volumehandler.go#L306-L309 

Added lines #L306 - L309 were not covered by tests
logger.V(1).Info("snapshot is ready to use")
// status.readyToUse either is not set by the driver at this point (even though
// status.BoundVolumeSnapshotContentName is set), or readyToUse=true

return snap, nil
}
Expand Down
Loading