Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skalomerge #85

Closed
wants to merge 5 commits into from
Closed

Skalomerge #85

wants to merge 5 commits into from

Conversation

jhellewell14
Copy link
Collaborator

  • I moved the code from https://github.com/rderelle/skalo/tree/main into two files: skalo.rs which contains the larger functions used lib.rs and skalo_utils that contains utility functions (some of which are quite similar to other utility functions already in the code.
  • I added a new command to the CLI: indel that can either accept a .skf file and run the skalo model or take a list of .fasta files and run ska build before passing the ska array internally to the skalo model.
  • The skalo code remains mostly unchanged apart from where I have integrated it into the ska.rust code and fixed a few easy clippy warnings

@rderelle
Copy link
Collaborator

Hi Joel, I'm afraid this isn't the right version of skalo. Sorry about this. I'll upload it tonight and let you know.

@johnlees
Copy link
Member

@rderelle If you are also able to provide us with a good example input file and expected output that would also be very helpful

@rderelle
Copy link
Collaborator

skalo has been updated (v1.0.0) and this new version is Clippy-compliant.

I put a skf file on my google drive (20 simulated samples and k=21) - 250 SNPs are expected with default parameters.
https://drive.google.com/drive/folders/1OWEQtq0UdnzZMPEIi-X0O_wxqEPn1mOo?usp=sharing

@jhellewell14
Copy link
Collaborator Author

New PR with latest skalo version here: #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants